* [PATCH net-next-2.6] virtio_net: Set vlan_features to enable offloads on vlan devices
@ 2010-01-25 21:16 Sridhar Samudrala
2010-02-02 15:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sridhar Samudrala @ 2010-01-25 21:16 UTC (permalink / raw)
To: David Miller, Herbert Xu, rusty; +Cc: netdev
Set vlan_features in virtnet_probe() so that all the available offloads
are enabled on vlan devices attached to virtio_net devices.
Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -872,6 +872,8 @@ static int virtnet_probe(struct virtio_device *vdev)
dev->features |= NETIF_F_UFO;
}
+ dev->vlan_features = dev->features;
+
/* Configuration may specify what MAC to use. Otherwise random. */
if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) {
vdev->config->get(vdev,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next-2.6] virtio_net: Set vlan_features to enable offloads on vlan devices
2010-01-25 21:16 [PATCH net-next-2.6] virtio_net: Set vlan_features to enable offloads on vlan devices Sridhar Samudrala
@ 2010-02-02 15:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-02-02 15:46 UTC (permalink / raw)
To: sri; +Cc: herbert, rusty, netdev
From: Sridhar Samudrala <sri@us.ibm.com>
Date: Mon, 25 Jan 2010 13:16:16 -0800
> Set vlan_features in virtnet_probe() so that all the available offloads
> are enabled on vlan devices attached to virtio_net devices.
>
> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
I can't apply this because I'm not going to apply your
patch which erroneously pops the VLAN header during GRO
processing. And this patch is useless without that.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-02 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-25 21:16 [PATCH net-next-2.6] virtio_net: Set vlan_features to enable offloads on vlan devices Sridhar Samudrala
2010-02-02 15:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).