From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next-2.6] net: use helpers to access mc list Date: Tue, 02 Feb 2010 09:03:02 -0800 (PST) Message-ID: <20100202.090302.236843497.davem@davemloft.net> References: <20100202160347.GB2601@psychotron.lab.eng.brq.redhat.com> <20100202.080601.255528829.davem@davemloft.net> <20100202163107.GC2601@psychotron.lab.eng.brq.redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: jpirko@redhat.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:50484 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756704Ab0BBRCt (ORCPT ); Tue, 2 Feb 2010 12:02:49 -0500 In-Reply-To: <20100202163107.GC2601@psychotron.lab.eng.brq.redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Tue, 2 Feb 2010 17:31:08 +0100 > Tue, Feb 02, 2010 at 05:06:01PM CET, davem@davemloft.net wrote: >>From: Jiri Pirko >>Date: Tue, 2 Feb 2010 17:03:48 +0100 >> >>> You mean "struct dev_mc_list"? But that would solve nothing. If I would still >>> use current structure in drivers, then still the migration to struct_hw_addr >>> would be all-at-once for all drivers :( This patch was exacly made to avoid >>> this. >> >>I think changing the iterator type will have to be done >>wholesale in one changeset, there is no reasonable way >>to avoid it. > > So what you are proposing is to change drivers' code to use macro to iterate > through lists as step n1 and then change the iterator type as step n2 right? > > If we would use my patch, we would have this done in single step. But I understand > that a kind of ugliness patch introduces is simply not acceptable not even for a > short time period, right? Right.