From: David Miller <davem@davemloft.net>
To: ktpedre@sandia.gov
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] seastar - SeaStar Ethernet driver
Date: Tue, 02 Feb 2010 17:40:45 -0800 (PST) [thread overview]
Message-ID: <20100202.174045.135005544.davem@davemloft.net> (raw)
In-Reply-To: <1265160242.15726.20.camel@hawkeye.sandia.gov>
From: "Kevin Pedretti" <ktpedre@sandia.gov>
Date: Tue, 2 Feb 2010 18:24:02 -0700
> 4. Device only supports IPv4? -> Yes, that's correct. No IPv6 support.
> The driver squashes everything but IPv4 in eth2ss().
Not just IPV6, what about other ethernet protocols?
What about ARP? How does IPV4 work if you only accept ETH_P_IP? You
need to accept at least ETH_P_ARP for things to work.
> 2. May want to use alloc_netdev() -> Didn't do this. Would there be a
> substantial advantage to doing this?
I think you're going to end up having to make this change.
next prev parent reply other threads:[~2010-02-03 1:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 20:58 [PATCH] seastar - SeaStar Ethernet driver Kevin Pedretti
2010-02-02 21:42 ` David Miller
2010-02-03 1:24 ` Kevin Pedretti
2010-02-03 1:40 ` David Miller [this message]
2010-02-03 1:41 ` David Miller
2010-02-04 23:01 ` Kevin Pedretti
2010-02-04 23:13 ` David Miller
2010-02-05 0:36 ` Kevin Pedretti
2010-02-05 1:04 ` David Miller
2010-02-04 23:16 ` Alan Cox
2010-02-05 0:59 ` Kevin Pedretti
2010-02-03 16:12 ` Randy Dunlap
2010-02-02 21:59 ` Randy Dunlap
2010-02-02 22:12 ` Ben Hutchings
2010-02-02 23:38 ` Stephen Hemminger
2010-02-03 1:08 ` [PATCH] seastar - SeaStar Ethernet driver (review comments addressed) Kevin Pedretti
2010-02-03 1:39 ` Stephen Hemminger
2010-02-03 2:02 ` Joe Perches
2010-02-03 2:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202.174045.135005544.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ktpedre@sandia.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).