From: Yury Polyanskiy <ypolyans@princeton.edu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Wei Yongjun <yjwei@cn.fujitsu.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
polyanskiy@gmail.com, Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hrtimer, softirq: Fix hrtimer->softirq trampoline
Date: Tue, 2 Feb 2010 09:28:14 -0500 [thread overview]
Message-ID: <20100202092814.064a89c0@penta.localdomain> (raw)
In-Reply-To: <1265120401.24455.306.camel@laptop>
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
On Tue, 02 Feb 2010 15:20:01 +0100
Peter Zijlstra <peterz@infradead.org> wrote:
> static enum hrtimer_restart __hrtimer_tasklet_trampoline(struct hrtimer *timer)
> {
> struct tasklet_hrtimer *ttimer =
> container_of(timer, struct tasklet_hrtimer, timer);
>
> - if (hrtimer_is_hres_active(timer)) {
> - tasklet_hi_schedule(&ttimer->tasklet);
> - return HRTIMER_NORESTART;
> - }
> - return ttimer->function(timer);
> + tasklet_hi_schedule(&ttimer->tasklet);
> + return HRTIMER_NORESTART;
> }
>
Are you totally against if(in_irq())?
Yury
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-02-02 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 10:01 [BUG]? xfrm: INFO: inconsistent lock state Wei Yongjun
2010-02-02 7:49 ` Herbert Xu
2010-02-02 13:51 ` Yury Polyanskiy
2010-02-02 14:20 ` [PATCH] hrtimer, softirq: Fix hrtimer->softirq trampoline Peter Zijlstra
2010-02-02 14:28 ` Yury Polyanskiy [this message]
2010-02-02 14:35 ` Peter Zijlstra
2010-02-03 1:47 ` Wei Yongjun
2010-02-03 16:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202092814.064a89c0@penta.localdomain \
--to=ypolyans@princeton.edu \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=polyanskiy@gmail.com \
--cc=tglx@linutronix.de \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).