netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jpirko@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net: use helpers to access mc list
Date: Tue, 2 Feb 2010 17:31:08 +0100	[thread overview]
Message-ID: <20100202163107.GC2601@psychotron.lab.eng.brq.redhat.com> (raw)
In-Reply-To: <20100202.080601.255528829.davem@davemloft.net>

Tue, Feb 02, 2010 at 05:06:01PM CET, davem@davemloft.net wrote:
>From: Jiri Pirko <jpirko@redhat.com>
>Date: Tue, 2 Feb 2010 17:03:48 +0100
>
>> You mean "struct dev_mc_list"? But that would solve nothing. If I would still
>> use current structure in drivers, then still the migration to struct_hw_addr
>> would be all-at-once for all drivers :( This patch was exacly made to avoid
>> this.
>
>I think changing the iterator type will have to be done
>wholesale in one changeset, there is no reasonable way
>to avoid it.

So what you are proposing is to change drivers' code to use macro to iterate
through lists as step n1 and then change the iterator type as step n2 right?

If we would use my patch, we would have this done in single step. But I understand
that a kind of ugliness patch introduces is simply not acceptable not even for a
short time period, right?

Thanks

Jirka

  reply	other threads:[~2010-02-02 16:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26 14:57 [PATCH net-next-2.6] net: use helpers to access mc list Jiri Pirko
2010-02-02 15:25 ` David Miller
2010-02-02 16:03   ` Jiri Pirko
2010-02-02 16:06     ` David Miller
2010-02-02 16:31       ` Jiri Pirko [this message]
2010-02-02 17:03         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100202163107.GC2601@psychotron.lab.eng.brq.redhat.com \
    --to=jpirko@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).