From: Stephen Hemminger <shemminger@vyatta.com>
To: Joe Perches <joe@perches.com>
Cc: Kevin Pedretti <ktpedre@sandia.gov>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] seastar - SeaStar Ethernet driver (review comments addressed)
Date: Tue, 2 Feb 2010 18:07:57 -0800 [thread overview]
Message-ID: <20100202180757.51078dad@nehalam> (raw)
In-Reply-To: <1265162522.1945.148.camel@Joe-Laptop.home>
On Tue, 02 Feb 2010 18:02:01 -0800
Joe Perches <joe@perches.com> wrote:
> Presumably SeaStar doesn't support multicast either, so maybe:
> if (dest_low_mac & 0x01)
Why not:
if (is_multicast_ether_addr(ethdr->h_dest))
...
prev parent reply other threads:[~2010-02-03 2:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 20:58 [PATCH] seastar - SeaStar Ethernet driver Kevin Pedretti
2010-02-02 21:42 ` David Miller
2010-02-03 1:24 ` Kevin Pedretti
2010-02-03 1:40 ` David Miller
2010-02-03 1:41 ` David Miller
2010-02-04 23:01 ` Kevin Pedretti
2010-02-04 23:13 ` David Miller
2010-02-05 0:36 ` Kevin Pedretti
2010-02-05 1:04 ` David Miller
2010-02-04 23:16 ` Alan Cox
2010-02-05 0:59 ` Kevin Pedretti
2010-02-03 16:12 ` Randy Dunlap
2010-02-02 21:59 ` Randy Dunlap
2010-02-02 22:12 ` Ben Hutchings
2010-02-02 23:38 ` Stephen Hemminger
2010-02-03 1:08 ` [PATCH] seastar - SeaStar Ethernet driver (review comments addressed) Kevin Pedretti
2010-02-03 1:39 ` Stephen Hemminger
2010-02-03 2:02 ` Joe Perches
2010-02-03 2:07 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202180757.51078dad@nehalam \
--to=shemminger@vyatta.com \
--cc=joe@perches.com \
--cc=ktpedre@sandia.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox