From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] NAPI as kobject proposal
Date: Wed, 03 Feb 2010 17:33:05 -0800 (PST) [thread overview]
Message-ID: <20100203.173305.196876047.davem@davemloft.net> (raw)
In-Reply-To: <20100129101839.36944ba5@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 29 Jan 2010 10:18:39 -0800
> As part of receive packet steering there is a requirement to add an
> additional parameter to this for the CPU map.
Hmmm, where did this come from?
The RPS maps are per-device.
I think I vaguely recall you "suggesting" that the RPS maps become
per-NAPI.
But, firstly, I didn't see any movement in that part of the
discussion.
And, secondly, I don't think this makes any sense at all.
Things are already overly complicated as it is. Having the user know
what traffic goes to a particular RX queue (ie. NAPI instance) and set
the RPS map in some way specific to that RX queue is over the top.
If the issue is the case of sharing a NAPI instance between two
devices, there are a few other ways to deal with this.
One I would suggest is to simply clone the RPS map amongst the
devices sharing a NAPI instance.
I currently see NAPI kobjects is just an over-abstraction for a
perceived need rather than a real one.
next prev parent reply other threads:[~2010-02-04 1:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 18:18 [RFC] NAPI as kobject proposal Stephen Hemminger
2010-02-03 21:23 ` Ben Hutchings
2010-02-03 21:26 ` Al Viro
2010-02-03 21:41 ` Stephen Hemminger
2010-02-03 21:38 ` David Daney
2010-02-04 1:33 ` David Miller [this message]
2010-02-04 1:58 ` Stephen Hemminger
2010-02-04 2:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203.173305.196876047.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).