From: David Miller <davem@davemloft.net>
To: Tristram.Ha@Micrel.Com
Cc: alan@lxorguk.ukuu.org.uk, shemminger@vyatta.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.33 1/4] net: Micrel KSZ8841/2 PCI Ethernet driver
Date: Wed, 03 Feb 2010 18:00:56 -0800 (PST) [thread overview]
Message-ID: <20100203.180056.206222084.davem@davemloft.net> (raw)
In-Reply-To: <14385191E87B904DBD836449AA30269D021A4D@MORGANITE.micrel.com>
From: "Ha, Tristram" <Tristram.Ha@Micrel.Com>
Date: Fri, 29 Jan 2010 14:37:22 -0800
> This is a resubmission of the Micrel KSZ8841/2 PCI Ethernet driver.
The procfs stuff is a non-starter.
There will undoubtedly be other devices that have switch-like
facilities that we'd like to export configuration support for.
The last thing we want is a bunch of procfs files that each
driver decides the layout and behavior of.
We need a centralized way to config such things, and probably
the best is to have a rtnl_link_ops facility to get at the
ports and configure them with attribute blobs or similar.
We also said in your first submission that the way you're
getting at the bridge STP stuff with things like:
+/* Needed for STP support. */
+#ifdef CONFIG_KSZ8842_STP
+#include <../net/bridge/br_private.h>
+#endif
Yet you left all of this stuff in there.
next prev parent reply other threads:[~2010-02-04 2:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 22:37 [PATCH 2.6.33 1/4] net: Micrel KSZ8841/2 PCI Ethernet driver Ha, Tristram
2010-02-04 2:00 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-04 23:18 Ha, Tristram
2010-02-04 23:38 ` Stephen Hemminger
2010-02-04 23:22 Ha, Tristram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203.180056.206222084.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Tristram.Ha@Micrel.Com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).