From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: gerrit@erg.abdn.ac.uk, dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 01/86] dccp: fix bug in cache allocation
Date: Wed, 03 Feb 2010 19:01:54 -0800 (PST) [thread overview]
Message-ID: <20100203.190154.46617335.davem@davemloft.net> (raw)
In-Reply-To: <20100201115638.GB25094@hmsreliant.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 1 Feb 2010 06:56:38 -0500
> On Mon, Feb 01, 2010 at 07:18:06AM +0100, Gerrit Renker wrote:
>> This fixes a bug introduced in commit de4ef86cfce60d2250111f34f8a084e769f23b16
>> ("dccp: fix dccp rmmod when kernel configured to use slub", 17 Jan): the
>> vsnprintf used sizeof(slab_name_fmt), which became truncated to 4 bytes, since
>> slab_name_fmt is now a 4-byte pointer and no longer a 32-character array.
>>
>> This lead to error messages such as
>> FATAL: Error inserting dccp: No buffer space available
>>
>> >> kernel: [ 1456.341501] kmem_cache_create: duplicate cache cci
>> generated due to the truncation after the 3rrdc character.
>>
>> Fixed for the moment by introducing a symbolic constant. Tested to fix the bug.
>>
>> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
>
> These changes make sense, sorry for not seeing that earlier. Thanks!
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied.
next prev parent reply other threads:[~2010-02-04 3:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <recent-dccp-bug-fixes-jan-2010>
2010-02-01 6:18 ` [BUG-FIX][PATCH 0/2]: recent dccp fixes Gerrit Renker
2010-02-01 6:18 ` [PATCH 01/86] dccp: fix bug in cache allocation Gerrit Renker
2010-02-01 6:18 ` [PATCH 02/86] dccp: revert buggy auto-loading of dccp module Gerrit Renker
2010-02-01 12:21 ` Neil Horman
2010-02-01 18:38 ` Neil Horman
2010-02-02 15:06 ` gerrit
2010-02-02 15:39 ` Neil Horman
2010-02-03 6:16 ` [PATCH v2 1/1] dccp: fix auto-loading of dccp(_probe) Gerrit Renker
2010-02-03 11:58 ` Neil Horman
2010-02-04 3:01 ` David Miller
2010-02-01 11:56 ` [PATCH 01/86] dccp: fix bug in cache allocation Neil Horman
2010-02-01 12:08 ` Gerrit Renker
2010-02-01 12:12 ` [BUG-FIX v2][PATCH 0/2]: recent dccp fixes Gerrit Renker
2010-02-01 12:12 ` [Bug-Fix][PATCH 1/2] dccp: fix bug in cache allocation Gerrit Renker
2010-02-01 12:12 ` [Bug-Fix][PATCH 2/2] dccp: revert buggy auto-loading of dccp module Gerrit Renker
2010-02-04 3:01 ` David Miller [this message]
2010-02-01 7:17 ` [BUG-FIX][PATCH 0/2]: recent dccp fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203.190154.46617335.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).