From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, anton@samba.org
Subject: Re: [net-2.6 PATCH 1/2] ixgbe: Fix ixgbe_tx_map error path
Date: Wed, 03 Feb 2010 19:17:26 -0800 (PST) [thread overview]
Message-ID: <20100203.191726.190578844.davem@davemloft.net> (raw)
In-Reply-To: <20100203231224.15352.27988.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 03 Feb 2010 15:12:51 -0800
> From: Anton Blanchard <anton@samba.org>
>
> Commit e5a43549f7a58509a91b299a51337d386697b92c (ixgbe: remove
> skb_dma_map/unmap calls from driver) looks to have introduced a bug in
> ixgbe_tx_map. If we get an error from a PCI DMA call, we loop backwards
> through count until it becomes -1 and return that.
>
> The caller of ixgbe_tx_map expects 0 on error, so return that instead.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2010-02-04 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 23:12 [net-2.6 PATCH 1/2] ixgbe: Fix ixgbe_tx_map error path Jeff Kirsher
2010-02-03 23:13 ` [net-2.6 PATCH 2/2] ixgbe: Fix return of invalid txq Jeff Kirsher
2010-02-04 3:17 ` David Miller
2010-02-04 3:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203.191726.190578844.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anton@samba.org \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).