From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, john.r.fastabend@intel.com
Subject: Re: [net-next-2.6 PATCH v2] ixgbe: only process one ixgbe_watchdog_task at a time.
Date: Wed, 03 Feb 2010 19:47:07 -0800 (PST) [thread overview]
Message-ID: <20100203.194707.57344587.davem@davemloft.net> (raw)
In-Reply-To: <20100204002331.15847.40084.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 03 Feb 2010 16:23:32 -0800
> From: John Fastabend <john.r.fastabend@intel.com>
>
> Processing multiple ixgbe_watchdog_task calls may cause
> the link_up variable and IXGBE_FLAG_NEED_LINK_UPDATE flag
> to be set incorrectly. In the worse case this is causing
> the netif_carrier_off to be called inappropriately which
> results in an interface that can't be brought up.
>
> Although schedule_work() will only schedule the task if
> it is not already on the work queue the WORK_STRUCT_PENDING
> bits are cleared just before calling the work function.
> This allows WORK_STRUCT_PENDING to be cleared, the work
> function to start and meanwhile schedule another task.
>
> This patch adds a mutex to the watchdog task. This bug is
> actualized by changing DCB settings or doing extended
> cable pull or reset tests.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2010-02-04 3:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 0:23 [net-next-2.6 PATCH v2] ixgbe: only process one ixgbe_watchdog_task at a time Jeff Kirsher
2010-02-04 3:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203.194707.57344587.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).