* [PATCH 1/2] irda: unbalanced lock_kernel in irnet_ppp
@ 2010-02-01 18:21 Thadeu Lima de Souza Cascardo
2010-02-01 18:21 ` [PATCH 2/2] irda: add missing BKL in irnet_ppp ioctl Thadeu Lima de Souza Cascardo
2010-02-04 4:14 ` [PATCH 1/2] irda: unbalanced lock_kernel in irnet_ppp David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2010-02-01 18:21 UTC (permalink / raw)
To: Alan Cox
Cc: Thadeu Lima de Souza Cascardo, Samuel Ortiz, David S. Miller,
linux-kernel, netdev
Add the missing unlock_kernel in one ioctl operation.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
net/irda/irnet/irnet_ppp.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/irda/irnet/irnet_ppp.c b/net/irda/irnet/irnet_ppp.c
index d6b502c..8d38fdd 100644
--- a/net/irda/irnet/irnet_ppp.c
+++ b/net/irda/irnet/irnet_ppp.c
@@ -703,7 +703,8 @@ dev_irnet_ioctl(
lock_kernel();
if(ap->ppp_open && !put_user(ppp_unit_number(&ap->chan),
(int __user *)argp))
- err = 0;
+ err = 0;
+ unlock_kernel();
break;
/* All these ioctls can be passed both directly and from ppp_generic,
--
1.6.6.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] irda: add missing BKL in irnet_ppp ioctl
2010-02-01 18:21 [PATCH 1/2] irda: unbalanced lock_kernel in irnet_ppp Thadeu Lima de Souza Cascardo
@ 2010-02-01 18:21 ` Thadeu Lima de Souza Cascardo
2010-02-04 4:15 ` David Miller
2010-02-04 4:14 ` [PATCH 1/2] irda: unbalanced lock_kernel in irnet_ppp David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2010-02-01 18:21 UTC (permalink / raw)
To: Alan Cox
Cc: Thadeu Lima de Souza Cascardo, Samuel Ortiz, David S. Miller,
linux-kernel, netdev
One ioctl has been forgotten when the BKL was push down into irnet_ppp
ioctl function.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
net/irda/irnet/irnet_ppp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/irda/irnet/irnet_ppp.c b/net/irda/irnet/irnet_ppp.c
index 8d38fdd..67aee5c 100644
--- a/net/irda/irnet/irnet_ppp.c
+++ b/net/irda/irnet/irnet_ppp.c
@@ -695,9 +695,11 @@ dev_irnet_ioctl(
/* Query PPP channel and unit number */
case PPPIOCGCHAN:
+ lock_kernel();
if(ap->ppp_open && !put_user(ppp_channel_index(&ap->chan),
(int __user *)argp))
err = 0;
+ unlock_kernel();
break;
case PPPIOCGUNIT:
lock_kernel();
--
1.6.6.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] irda: unbalanced lock_kernel in irnet_ppp
2010-02-01 18:21 [PATCH 1/2] irda: unbalanced lock_kernel in irnet_ppp Thadeu Lima de Souza Cascardo
2010-02-01 18:21 ` [PATCH 2/2] irda: add missing BKL in irnet_ppp ioctl Thadeu Lima de Souza Cascardo
@ 2010-02-04 4:14 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2010-02-04 4:14 UTC (permalink / raw)
To: cascardo; +Cc: alan, samuel, linux-kernel, netdev
From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Date: Mon, 1 Feb 2010 16:21:34 -0200
> Add the missing unlock_kernel in one ioctl operation.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-02-04 4:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-01 18:21 [PATCH 1/2] irda: unbalanced lock_kernel in irnet_ppp Thadeu Lima de Souza Cascardo
2010-02-01 18:21 ` [PATCH 2/2] irda: add missing BKL in irnet_ppp ioctl Thadeu Lima de Souza Cascardo
2010-02-04 4:15 ` David Miller
2010-02-04 4:14 ` [PATCH 1/2] irda: unbalanced lock_kernel in irnet_ppp David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).