* [patch 3/4] isdn: mISDN, don't compile unused stuff
@ 2010-02-02 22:43 akpm
2010-02-04 4:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2010-02-02 22:43 UTC (permalink / raw)
To: isdn; +Cc: netdev, akpm, jirislaby
From: Jiri Slaby <jirislaby@gmail.com>
Remove these compiler warnings:
drivers/isdn/hardware/mISDN/w6692.c:534: warning: `setvolume' defined but not used
drivers/isdn/hardware/mISDN/w6692.c:561: warning: `enable_pots' defined but not used
by moving the functions inside #if 0 ... #endif. And an alternative is
to remove them completely if nobody has plans to use them.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/isdn/hardware/mISDN/w6692.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN drivers/isdn/hardware/mISDN/w6692.c~isdn-misdn-dont-compile-unused-stuff drivers/isdn/hardware/mISDN/w6692.c
--- a/drivers/isdn/hardware/mISDN/w6692.c~isdn-misdn-dont-compile-unused-stuff
+++ a/drivers/isdn/hardware/mISDN/w6692.c
@@ -529,6 +529,7 @@ W6692_fill_Bfifo(struct w6692_ch *wch)
}
}
+#if 0
static int
setvolume(struct w6692_ch *wch, int mic, struct sk_buff *skb)
{
@@ -571,6 +572,7 @@ enable_pots(struct w6692_ch *wch)
WriteW6692(card, W_PCTL, card->pctl);
return 0;
}
+#endif
static int
disable_pots(struct w6692_ch *wch)
_
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch 3/4] isdn: mISDN, don't compile unused stuff
2010-02-02 22:43 [patch 3/4] isdn: mISDN, don't compile unused stuff akpm
@ 2010-02-04 4:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-02-04 4:17 UTC (permalink / raw)
To: akpm; +Cc: isdn, netdev, jirislaby
From: akpm@linux-foundation.org
Date: Tue, 02 Feb 2010 14:43:46 -0800
> From: Jiri Slaby <jirislaby@gmail.com>
>
> Remove these compiler warnings:
>
> drivers/isdn/hardware/mISDN/w6692.c:534: warning: `setvolume' defined but not used
> drivers/isdn/hardware/mISDN/w6692.c:561: warning: `enable_pots' defined but not used
>
> by moving the functions inside #if 0 ... #endif. And an alternative is
> to remove them completely if nobody has plans to use them.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Karsten Keil <isdn@linux-pingi.de>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-04 4:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-02 22:43 [patch 3/4] isdn: mISDN, don't compile unused stuff akpm
2010-02-04 4:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).