From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com,
peter.p.waskiewicz.jr@intel.com
Subject: Re: [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter programming support
Date: Thu, 04 Feb 2010 09:18:54 -0800 (PST) [thread overview]
Message-ID: <20100204.091854.24215476.davem@davemloft.net> (raw)
In-Reply-To: <20100204074811.16559.84676.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 03 Feb 2010 23:48:13 -0800
> +#define ETHTOOL_RXNTUPLE_ACTION_DROP -1
> + struct list_head list;
> +};
You can't do this.
You put the list_head here in the kernel header, which BTW can
be used by userspace too, and then you elide it in the
ethtool utility copy of the header.
Use an encapsulator if you must inside of the kernel, but keep the
userspace visible data structure clean of RCU and list_head
kernel datastructures.
Thanks.
next prev parent reply other threads:[~2010-02-04 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 7:48 [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter programming support Jeff Kirsher
2010-02-04 7:48 ` [net-next-2.6 PATCH v2 2/3] ixgbe: Add support for the new ethtool n-tuple programming interface Jeff Kirsher
2010-02-04 7:48 ` [net-next-2.6 PATCH v2 3/3] ixgbe: Bump driver version up Jeff Kirsher
2010-02-04 17:18 ` David Miller [this message]
2010-02-04 21:26 ` [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter programming support Waskiewicz Jr, Peter P
2010-02-04 22:34 ` Jeff Garzik
2010-02-04 22:52 ` Peter P Waskiewicz Jr
2010-02-04 22:55 ` Jeff Garzik
2010-02-04 23:07 ` Peter P Waskiewicz Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204.091854.24215476.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).