* [PATCH] can: ems_usb: removed duplicated code setting local echo support
@ 2010-02-01 18:02 Thadeu Lima de Souza Cascardo
2010-02-04 4:32 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2010-02-01 18:02 UTC (permalink / raw)
To: trivial
Cc: Thadeu Lima de Souza Cascardo, Urs Thuermann, Oliver Hartkopp,
netdev, linux-kernel
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
drivers/net/can/usb/ems_usb.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
index efbb05c..ee849cf 100644
--- a/drivers/net/can/usb/ems_usb.c
+++ b/drivers/net/can/usb/ems_usb.c
@@ -1020,8 +1020,6 @@ static int ems_usb_probe(struct usb_interface *intf,
dev->can.do_set_bittiming = ems_usb_set_bittiming;
dev->can.do_set_mode = ems_usb_set_mode;
- netdev->flags |= IFF_ECHO; /* we support local echo */
-
netdev->netdev_ops = &ems_usb_netdev_ops;
netdev->flags |= IFF_ECHO; /* we support local echo */
--
1.6.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] can: ems_usb: removed duplicated code setting local echo support
2010-02-01 18:02 [PATCH] can: ems_usb: removed duplicated code setting local echo support Thadeu Lima de Souza Cascardo
@ 2010-02-04 4:32 ` David Miller
2010-02-04 15:33 ` Thadeu Lima de Souza Cascardo
2010-02-04 15:34 ` cascardo
0 siblings, 2 replies; 5+ messages in thread
From: David Miller @ 2010-02-04 4:32 UTC (permalink / raw)
To: cascardo; +Cc: trivial, urs.thuermann, oliver.hartkopp, netdev, linux-kernel
From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Date: Mon, 1 Feb 2010 16:02:06 -0200
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
This doesn't apply to net-next-2.6
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] can: ems_usb: removed duplicated code setting local echo support
2010-02-04 4:32 ` David Miller
@ 2010-02-04 15:33 ` Thadeu Lima de Souza Cascardo
2010-02-04 17:21 ` David Miller
2010-02-04 15:34 ` cascardo
1 sibling, 1 reply; 5+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2010-02-04 15:33 UTC (permalink / raw)
To: davem
Cc: Thadeu Lima de Souza Cascardo, Urs Thuermann, Oliver Hartkopp,
netdev, linux-kernel
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
drivers/net/can/usb/ems_usb.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
index bfab283..11c8784 100644
--- a/drivers/net/can/usb/ems_usb.c
+++ b/drivers/net/can/usb/ems_usb.c
@@ -1024,8 +1024,6 @@ static int ems_usb_probe(struct usb_interface *intf,
dev->can.do_set_mode = ems_usb_set_mode;
dev->can.ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES;
- netdev->flags |= IFF_ECHO; /* we support local echo */
-
netdev->netdev_ops = &ems_usb_netdev_ops;
netdev->flags |= IFF_ECHO; /* we support local echo */
--
1.6.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] can: ems_usb: removed duplicated code setting local echo support
2010-02-04 4:32 ` David Miller
2010-02-04 15:33 ` Thadeu Lima de Souza Cascardo
@ 2010-02-04 15:34 ` cascardo
1 sibling, 0 replies; 5+ messages in thread
From: cascardo @ 2010-02-04 15:34 UTC (permalink / raw)
To: David Miller
Cc: trivial, urs.thuermann, oliver.hartkopp, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Wed, Feb 03, 2010 at 08:32:56PM -0800, David Miller wrote:
> From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> Date: Mon, 1 Feb 2010 16:02:06 -0200
>
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
>
> This doesn't apply to net-next-2.6
I have just resent a version cherry-picked on top of its master branch.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] can: ems_usb: removed duplicated code setting local echo support
2010-02-04 15:33 ` Thadeu Lima de Souza Cascardo
@ 2010-02-04 17:21 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2010-02-04 17:21 UTC (permalink / raw)
To: cascardo; +Cc: urs.thuermann, oliver.hartkopp, netdev, linux-kernel
From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Date: Thu, 4 Feb 2010 13:33:44 -0200
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-02-04 17:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-01 18:02 [PATCH] can: ems_usb: removed duplicated code setting local echo support Thadeu Lima de Souza Cascardo
2010-02-04 4:32 ` David Miller
2010-02-04 15:33 ` Thadeu Lima de Souza Cascardo
2010-02-04 17:21 ` David Miller
2010-02-04 15:34 ` cascardo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).