From: David Miller <davem@davemloft.net>
To: ron.mercer@qlogic.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH 3/3] qlge: Add watchdog timer.
Date: Thu, 04 Feb 2010 12:29:31 -0800 (PST) [thread overview]
Message-ID: <20100204.122931.189315763.davem@davemloft.net> (raw)
In-Reply-To: <20100204200603.GB9938@linux-ox1b.qlogic.org>
From: Ron Mercer <ron.mercer@qlogic.com>
Date: Thu, 4 Feb 2010 12:06:03 -0800
> +static void ql_timer(unsigned long data)
> +{
> + struct ql_adapter *qdev = (struct ql_adapter *)data;
> + u32 var = 0;
> +
> + var = ql_read32(qdev, STS);
> + if (pci_channel_offline(qdev->pdev)) {
> + QPRINTK(qdev, IFUP, ERR, "EEH STS = 0x%.08x.\n", var);
> + return;
> + }
> +
> + add_timer(&qdev->timer);
> +}
> +
Did the timer every fire more than once in your testing?
Don't you need to re-setup the expiration period before
adding it again?
Same goes for all of those sequences where you go:
del_timer_sync(&qdev->timer);
...
add_timer(&qdev->timer);
in the patch.
next prev parent reply other threads:[~2010-02-04 20:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 17:24 [net-next PATCH 0/3] qlge: EEH fixes Ron Mercer
2010-02-03 17:24 ` [net-next PATCH 1/3] qlge: Move reset from eeh io_resume to slot_reset Ron Mercer
2010-02-04 4:06 ` David Miller
2010-02-03 17:24 ` [net-next PATCH 2/3] qlge: Add check for eeh failure when closing device Ron Mercer
2010-02-04 4:06 ` David Miller
2010-02-03 17:24 ` [net-next PATCH 3/3] qlge: Add watchdog timer Ron Mercer
2010-02-04 3:32 ` David Miller
2010-02-04 16:04 ` Ron Mercer
2010-02-04 20:06 ` Ron Mercer
2010-02-04 20:29 ` David Miller [this message]
2010-02-04 21:19 ` Ron Mercer
2010-02-04 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204.122931.189315763.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).