* [PATCH] Net / pktgen: Fix freezing problem
@ 2010-02-04 21:50 Rafael J. Wysocki
2010-02-04 22:00 ` David Miller
2010-02-04 22:12 ` Andrew Morton
0 siblings, 2 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2010-02-04 21:50 UTC (permalink / raw)
To: LKML; +Cc: NetDev, pm list, Andrew Morton, David Miller,
Ciprian Dorin Craciun
From: Rafael J. Wysocki <rjw@sisk.pl>
Subject: Net / pktgen: Fix freezing problem
Add missing try_to_freeze() to one of the pktgen_thread_worker() code
paths so that it doesn't block suspend/hibernation.
Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reported-and-tested-by: Ciprian Dorin Craciun <ciprian.craciun@gmail.com>
---
net/core/pktgen.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/net/core/pktgen.c
===================================================================
--- linux-2.6.orig/net/core/pktgen.c
+++ linux-2.6/net/core/pktgen.c
@@ -3524,6 +3524,7 @@ static int pktgen_thread_worker(void *ar
wait_event_interruptible_timeout(t->queue,
t->control != 0,
HZ/10);
+ try_to_freeze();
continue;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Net / pktgen: Fix freezing problem
2010-02-04 21:50 [PATCH] Net / pktgen: Fix freezing problem Rafael J. Wysocki
@ 2010-02-04 22:00 ` David Miller
2010-02-04 22:12 ` Andrew Morton
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2010-02-04 22:00 UTC (permalink / raw)
To: rjw; +Cc: linux-kernel, netdev, linux-pm, akpm, ciprian.craciun
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Thu, 4 Feb 2010 22:50:58 +0100
> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: Net / pktgen: Fix freezing problem
>
> Add missing try_to_freeze() to one of the pktgen_thread_worker() code
> paths so that it doesn't block suspend/hibernation.
>
> Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> Reported-and-tested-by: Ciprian Dorin Craciun <ciprian.craciun@gmail.com>
Applied, thanks a lot.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Net / pktgen: Fix freezing problem
2010-02-04 21:50 [PATCH] Net / pktgen: Fix freezing problem Rafael J. Wysocki
2010-02-04 22:00 ` David Miller
@ 2010-02-04 22:12 ` Andrew Morton
2010-02-04 22:19 ` Rafael J. Wysocki
2010-02-04 22:33 ` David Miller
1 sibling, 2 replies; 5+ messages in thread
From: Andrew Morton @ 2010-02-04 22:12 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: LKML, NetDev, pm list, David Miller, Ciprian Dorin Craciun
On Thu, 4 Feb 2010 22:50:58 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: Net / pktgen: Fix freezing problem
>
> Add missing try_to_freeze() to one of the pktgen_thread_worker() code
> paths so that it doesn't block suspend/hibernation.
>
> Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> Reported-and-tested-by: Ciprian Dorin Craciun <ciprian.craciun@gmail.com>
> ---
> net/core/pktgen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/net/core/pktgen.c
> ===================================================================
> --- linux-2.6.orig/net/core/pktgen.c
> +++ linux-2.6/net/core/pktgen.c
> @@ -3524,6 +3524,7 @@ static int pktgen_thread_worker(void *ar
> wait_event_interruptible_timeout(t->queue,
> t->control != 0,
> HZ/10);
> + try_to_freeze();
> continue;
> }
>
Also needed in -stable, IMO.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Net / pktgen: Fix freezing problem
2010-02-04 22:12 ` Andrew Morton
@ 2010-02-04 22:19 ` Rafael J. Wysocki
2010-02-04 22:33 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2010-02-04 22:19 UTC (permalink / raw)
To: Andrew Morton
Cc: LKML, NetDev, pm list, David Miller, Ciprian Dorin Craciun,
Greg KH
On Thursday 04 February 2010, Andrew Morton wrote:
> On Thu, 4 Feb 2010 22:50:58 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> > Subject: Net / pktgen: Fix freezing problem
> >
> > Add missing try_to_freeze() to one of the pktgen_thread_worker() code
> > paths so that it doesn't block suspend/hibernation.
> >
> > Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > Reported-and-tested-by: Ciprian Dorin Craciun <ciprian.craciun@gmail.com>
> > ---
> > net/core/pktgen.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > Index: linux-2.6/net/core/pktgen.c
> > ===================================================================
> > --- linux-2.6.orig/net/core/pktgen.c
> > +++ linux-2.6/net/core/pktgen.c
> > @@ -3524,6 +3524,7 @@ static int pktgen_thread_worker(void *ar
> > wait_event_interruptible_timeout(t->queue,
> > t->control != 0,
> > HZ/10);
> > + try_to_freeze();
> > continue;
> > }
> >
>
> Also needed in -stable, IMO.
Indeed.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Net / pktgen: Fix freezing problem
2010-02-04 22:12 ` Andrew Morton
2010-02-04 22:19 ` Rafael J. Wysocki
@ 2010-02-04 22:33 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2010-02-04 22:33 UTC (permalink / raw)
To: akpm; +Cc: rjw, linux-kernel, netdev, linux-pm, ciprian.craciun
From: Andrew Morton <akpm@linux-foundation.org>
Date: Thu, 4 Feb 2010 14:12:39 -0800
> Also needed in -stable, IMO.
I'll queue it up, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-02-04 22:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-04 21:50 [PATCH] Net / pktgen: Fix freezing problem Rafael J. Wysocki
2010-02-04 22:00 ` David Miller
2010-02-04 22:12 ` Andrew Morton
2010-02-04 22:19 ` Rafael J. Wysocki
2010-02-04 22:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).