From: David Miller <davem@davemloft.net>
To: Tristram.Ha@Micrel.Com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.33 4/4] net: Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices
Date: Thu, 04 Feb 2010 15:40:31 -0800 (PST) [thread overview]
Message-ID: <20100204.154031.124668996.davem@davemloft.net> (raw)
In-Reply-To: <14385191E87B904DBD836449AA30269D021A55@MORGANITE.micrel.com>
From: "Ha, Tristram" <Tristram.Ha@Micrel.Com>
Date: Thu, 4 Feb 2010 15:28:29 -0800
> From: Tristram Ha <Tristram.Ha@micrel.com>
>
> Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices.
>
> Signed-off-by: Tristram Ha <Tristram.Ha@micrel.com>
We no longer add device ID defines to the linux/pci_ids.h
file, in fact it's been this way for several years.
Just use constants or local devices in your driver.
Furthermore, because you made this the last patch, the
tree would fail to build at the point where the first
three of your patches are applied.
This breaks GIT bisection, and is severely frowned upon. The tree
must build with all available kernel config options enabled at every
step of applying your set of patches.
next prev parent reply other threads:[~2010-02-04 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 23:28 [PATCH 2.6.33 4/4] net: Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices Ha, Tristram
2010-02-04 23:40 ` Stephen Hemminger
2010-02-05 2:55 ` Ha, Tristram
2010-02-05 4:27 ` David Miller
2010-02-04 23:40 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-29 22:45 Ha, Tristram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204.154031.124668996.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Tristram.Ha@Micrel.Com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).