From: David Miller <davem@davemloft.net>
To: sri@us.ibm.com
Cc: herbert@gondor.apana.org.au, mst@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next-2.6] packet: Add GSO/csum offload support.
Date: Thu, 04 Feb 2010 15:49:01 -0800 (PST) [thread overview]
Message-ID: <20100204.154901.232299310.davem@davemloft.net> (raw)
In-Reply-To: <1265239340.5600.21.camel@w-sridhar.beaverton.ibm.com>
From: Sridhar Samudrala <sri@us.ibm.com>
Date: Wed, 03 Feb 2010 15:22:20 -0800
> This patch adds GSO/checksum offload to af_packet sockets using
> virtio_net_hdr. Based on Rusty's patch to add this support to tun.
> It allows GSO/checksum offload to be enabled when using raw socket
> backend with virtio_net.
> Adds PACKET_VNET_HDR socket option to prepend virtio_net_hdr in the
> receive path and process/skip virtio_net_hdr in the send path. This
> option is only allowed with SOCK_RAW sockets attached to ethernet
> type devices.
>
> v2 updates
> ----------
> Michael's Comments
> - Perform length check in packet_snd() when GSO is off even when
> vnet_hdr is present.
> - Check for SKB_GSO_FCOE type and return -EINVAL
> - don't allow tx/rx ring when vnet_hdr is enabled.
> Herbert's Comments
> - Removed ethernet specific code.
> - protocol value is assumed to be passed in by the caller.
>
> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
Herbert et al. could you guys review this?
Thanks.
next prev parent reply other threads:[~2010-02-04 23:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 23:22 [PATCH v2 net-next-2.6] packet: Add GSO/csum offload support Sridhar Samudrala
2010-02-04 23:49 ` David Miller [this message]
2010-02-05 0:08 ` Herbert Xu
2010-02-05 0:17 ` Sridhar Samudrala
2010-02-05 0:53 ` Herbert Xu
2010-02-05 0:52 ` Herbert Xu
2010-02-05 1:02 ` Sridhar Samudrala
2010-02-05 2:14 ` Herbert Xu
2010-02-05 4:25 ` David Miller
2010-02-06 0:20 ` Tantilov, Emil S
2010-02-06 0:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204.154901.232299310.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).