From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: sri@us.ibm.com, mst@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next-2.6] packet: Add GSO/csum offload support.
Date: Thu, 04 Feb 2010 20:25:28 -0800 (PST) [thread overview]
Message-ID: <20100204.202528.69423500.davem@davemloft.net> (raw)
In-Reply-To: <20100205021406.GA10651@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 5 Feb 2010 13:14:06 +1100
> On Thu, Feb 04, 2010 at 05:02:10PM -0800, Sridhar Samudrala wrote:
>>
>> In the case of SOCK_DGRAM reserve is not set and will be 0 and hence
>> it is same as calling skb_reset_network_header(skb)
>
> Thanks for the explanation. The patch looks good to me.
Patch applied, thanks everyone.
Sridhar, your patch had several cases of trailing whitespace which I
fixed up when applying. Because tools are able to find such errors in
an automated way, these kinds of things should never show up in a
patch submission. Please fix such things up before submitting patches
in the future.
Thanks again.
next prev parent reply other threads:[~2010-02-05 4:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 23:22 [PATCH v2 net-next-2.6] packet: Add GSO/csum offload support Sridhar Samudrala
2010-02-04 23:49 ` David Miller
2010-02-05 0:08 ` Herbert Xu
2010-02-05 0:17 ` Sridhar Samudrala
2010-02-05 0:53 ` Herbert Xu
2010-02-05 0:52 ` Herbert Xu
2010-02-05 1:02 ` Sridhar Samudrala
2010-02-05 2:14 ` Herbert Xu
2010-02-05 4:25 ` David Miller [this message]
2010-02-06 0:20 ` Tantilov, Emil S
2010-02-06 0:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204.202528.69423500.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).