From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
NetDev <netdev@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
David Miller <davem@davemloft.net>,
Ciprian Dorin Craciun <ciprian.craciun@gmail.com>,
Greg KH <gregkh@suse.de>
Subject: Re: [PATCH] Net / pktgen: Fix freezing problem
Date: Thu, 4 Feb 2010 23:19:22 +0100 [thread overview]
Message-ID: <201002042319.22226.rjw@sisk.pl> (raw)
In-Reply-To: <20100204141239.aa94e75c.akpm@linux-foundation.org>
On Thursday 04 February 2010, Andrew Morton wrote:
> On Thu, 4 Feb 2010 22:50:58 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> > Subject: Net / pktgen: Fix freezing problem
> >
> > Add missing try_to_freeze() to one of the pktgen_thread_worker() code
> > paths so that it doesn't block suspend/hibernation.
> >
> > Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > Reported-and-tested-by: Ciprian Dorin Craciun <ciprian.craciun@gmail.com>
> > ---
> > net/core/pktgen.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > Index: linux-2.6/net/core/pktgen.c
> > ===================================================================
> > --- linux-2.6.orig/net/core/pktgen.c
> > +++ linux-2.6/net/core/pktgen.c
> > @@ -3524,6 +3524,7 @@ static int pktgen_thread_worker(void *ar
> > wait_event_interruptible_timeout(t->queue,
> > t->control != 0,
> > HZ/10);
> > + try_to_freeze();
> > continue;
> > }
> >
>
> Also needed in -stable, IMO.
Indeed.
next prev parent reply other threads:[~2010-02-04 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 21:50 [PATCH] Net / pktgen: Fix freezing problem Rafael J. Wysocki
2010-02-04 22:00 ` David Miller
2010-02-04 22:12 ` Andrew Morton
2010-02-04 22:19 ` Rafael J. Wysocki [this message]
2010-02-04 22:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002042319.22226.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=ciprian.craciun@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).