From: Stephen Hemminger <shemminger@vyatta.com>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
Jay Vosburgh <fubar@us.ibm.com>,
netdev@vger.kernel.org, bonding-devel@lists.sourceforge.net
Subject: Re: [RFC 3/4] bond: support more Layer 4 protocols
Date: Fri, 5 Feb 2010 08:42:40 -0800 [thread overview]
Message-ID: <20100205084240.0bd895ab@s6510> (raw)
In-Reply-To: <4B6BF50D.9060603@trash.net>
On Fri, 05 Feb 2010 11:38:05 +0100
Patrick McHardy <kaber@trash.net> wrote:
> Stephen Hemminger wrote:
> > +/* Map of protocols with standard ports available to include in hash */
> > +static const bool has_layer4[256] = {
> > + [IPPROTO_TCP] = 1,
> > + [IPPROTO_UDP] = 1,
> > + [IPPROTO_UDPLITE] = 1,
> > + [IPPROTO_SCTP] = 1,
> > + [IPPROTO_DCCP] = 1,
> > + [IPPROTO_ESP] = 1,
> > +};
> > +
>
> How about using a bitmap or u8s to keep this more compact?
I thought about that, but couldn't find a clever way to initialize at
compile time other than hardcoding constants?
next prev parent reply other threads:[~2010-02-05 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 17:11 [RFC 0/4] bond hashing revised Stephen Hemminger
2010-02-04 17:11 ` [RFC 1/4] bond: cleanup transmit hash policy interface Stephen Hemminger
2010-02-04 17:11 ` [RFC 2/4] bond: add IPV6 layer3 hash policy support Stephen Hemminger
2010-02-04 17:11 ` [RFC 3/4] bond: support more Layer 4 protocols Stephen Hemminger
2010-02-05 10:38 ` Patrick McHardy
2010-02-05 16:42 ` Stephen Hemminger [this message]
2010-02-08 13:11 ` Patrick McHardy
2010-02-04 17:11 ` [RFC 4/4] bond: add new multiqueue hash policy Stephen Hemminger
2010-02-05 9:40 ` [RFC 0/4] bond hashing revised Jasper Spaans
2010-02-05 21:04 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205084240.0bd895ab@s6510 \
--to=shemminger@vyatta.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).