From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
kvm@vger.kernel.org, virtualization@lists.osdl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] vhost-net: switch to smp barriers
Date: Sun, 7 Feb 2010 11:44:42 +0200 [thread overview]
Message-ID: <20100207094441.GA20271@redhat.com> (raw)
In-Reply-To: <4B6E8B05.8070607@redhat.com>
On Sun, Feb 07, 2010 at 11:42:29AM +0200, Avi Kivity wrote:
> On 02/01/2010 07:21 PM, Michael S. Tsirkin wrote:
>> vhost-net only uses memory barriers to control SMP effects
>> (communication with userspace potentially running on a different CPU),
>> so it should use SMP barriers and not mandatory barriers for memory
>> access ordering, as suggested by Documentation/memory-barriers.txt
>>
>>
>
> A UP guest running on an SMP host still needs those barriers.
Correct. And since vhost net is running host-side, smp_XX
barriers will do exactly the right thing, right?
> --
> error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-02-07 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 17:21 [PATCH] vhost-net: switch to smp barriers Michael S. Tsirkin
2010-02-07 9:07 ` Michael S. Tsirkin
2010-02-08 8:19 ` Rusty Russell
2010-02-13 17:39 ` Michael S. Tsirkin
2010-02-14 19:55 ` David Miller
2010-02-07 9:42 ` Avi Kivity
2010-02-07 9:44 ` Michael S. Tsirkin [this message]
2010-02-07 9:56 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100207094441.GA20271@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).