From: David Miller <davem@davemloft.net>
To: linville@tuxdriver.com
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mb@bu3sch.de
Subject: Re: pull request: wireless-2.6 2010-02-10
Date: Wed, 10 Feb 2010 12:25:40 -0800 (PST) [thread overview]
Message-ID: <20100210.122540.149553948.davem@davemloft.net> (raw)
In-Reply-To: <20100210201953.GC3286@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Wed, 10 Feb 2010 15:19:54 -0500
> On Wed, Feb 10, 2010 at 11:36:58AM -0800, David Miller wrote:
>> From: Johannes Berg <johannes@sipsolutions.net>
>> Date: Wed, 10 Feb 2010 20:15:37 +0100
>>
>> > It was intentional -- that sdev doesn't even have an irq member, but
>> > nobody ever noticed because of the wrong ifdef.
>>
>> Ok, then this needs to be explained in the commit message.
>
> OK...mind if I just revert the current version and ask Michael to
> resubmit with an appropriate changelog entry?
Have you pulled this tree into others already? Why not
just pop out the commit and fix it's commit message, then
reapply?
Having the revert commit in there is really stupid just for this.
next prev parent reply other threads:[~2010-02-10 20:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 18:58 pull request: wireless-2.6 2010-02-10 John W. Linville
2010-02-10 19:07 ` David Miller
2010-02-10 19:15 ` Johannes Berg
2010-02-10 19:36 ` David Miller
2010-02-10 20:19 ` John W. Linville
2010-02-10 20:25 ` David Miller [this message]
2010-02-10 20:32 ` John W. Linville
2010-02-10 20:35 ` David Miller
2010-02-10 20:37 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210.122540.149553948.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).