From: David Miller <davem@davemloft.net>
To: lizf@cn.fujitsu.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 00/13] net: simplify seq_file code, revised
Date: Wed, 10 Feb 2010 12:29:47 -0800 (PST) [thread overview]
Message-ID: <20100210.122947.171052717.davem@davemloft.net> (raw)
In-Reply-To: <20100210.113115.28754681.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 10 Feb 2010 11:31:15 -0800 (PST)
> From: Li Zefan <lizf@cn.fujitsu.com>
> Date: Tue, 09 Feb 2010 17:18:01 +0800
>
>> This patchset introduces seq_hlist_foo() helpers, and convert
>> net/* to seq_hlist_foo() and seq_list_foo().
>>
>> Changelog:
>>
>> - Add kerneldoc in patch 1/13
>> - Fix compile warning in patch 11/13
>> - Fix a bug in patch 12/13
>
> All applied to net-next-2.6, thanks!
You did not build test your changes.
net/irda/irlan/irlan_common.c:1156: error: 'struct irlan_cb' has no member named 'list'
net/irda/irlan/irlan_common.c:1156: warning: type defaults to 'int' in declaration of '__mptr'
net/irda/irlan/irlan_common.c:1156: error: 'struct irlan_cb' has no member named 'list'
I'll fix this, but I will not next time. Instead, I'll revert all of
your changes and push it back to you.
Thanks.
prev parent reply other threads:[~2010-02-10 20:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 9:18 [PATCH 00/13] net: simplify seq_file code, revised Li Zefan
2010-02-09 9:18 ` [PATCH 01/13] seq_file: Add helpers for iteration over a hlist Li Zefan
2010-02-09 9:18 ` [PATCH 02/13] net: add a wrapper sk_entry() Li Zefan
2010-02-09 9:19 ` [PATCH 03/13] net: x25: use seq_hlist_foo() helpers Li Zefan
2010-02-09 9:19 ` [PATCH 04/13] net: rose: " Li Zefan
2010-02-09 9:19 ` [PATCH 05/13] net: packet: " Li Zefan
2010-02-09 9:19 ` [PATCH 06/13] net: netrom: " Li Zefan
2010-02-09 9:19 ` [PATCH 07/13] net: ax25: " Li Zefan
2010-02-09 9:20 ` [PATCH 08/13] net: appletalk: " Li Zefan
2010-02-09 9:20 ` [PATCH 09/13] net: af_key: " Li Zefan
2010-02-09 9:20 ` [PATCH 10/13] net: x25: use seq_list_foo() helpers Li Zefan
2010-02-09 9:21 ` [PATCH 11/13] net: irda: " Li Zefan
2010-02-09 9:21 ` [PATCH 12/13] net: ipx: " Li Zefan
2010-02-09 9:21 ` [PATCH 13/13] net: atm: " Li Zefan
2010-02-10 19:31 ` [PATCH 00/13] net: simplify seq_file code, revised David Miller
2010-02-10 20:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210.122947.171052717.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).