From: David Miller <davem@davemloft.net>
To: maximlevitsky@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
maxim-levitsky@gmail.com
Subject: Re: [PATCH 2/6] DMFE: move pci ID definitions into pci_ids.h and clean up the code
Date: Wed, 10 Feb 2010 13:18:49 -0800 (PST) [thread overview]
Message-ID: <20100210.131849.237007566.davem@davemloft.net> (raw)
In-Reply-To: <1265487542-4447-3-git-send-email-maximlevitsky@gmail.com>
From: Maxim Levitsky <maximlevitsky@gmail.com>
Date: Sat, 6 Feb 2010 22:18:58 +0200
> Signed-off-by: Maxim Levitsky <maxim-levitsky@gmail.com>
We don't add new definitions to pci_ids.h that will only
be used in a single driver.
Instead, we just use the raw constants (if it's only referenced once,
say in the PCI ID table for the driver) or using local definitions
(if used multiple times in the driver).
next prev parent reply other threads:[~2010-02-10 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 20:18 Some fixes and cleanups for DMFE nework driver Maxim Levitsky
2010-02-06 20:18 ` [PATCH 1/6] dmfe: trivial cleanups: Maxim Levitsky
2010-02-06 20:18 ` [PATCH 2/6] DMFE: move pci ID definitions into pci_ids.h and clean up the code Maxim Levitsky
2010-02-10 21:18 ` David Miller [this message]
2010-02-10 21:22 ` David Miller
2010-02-11 17:25 ` Maxim Levitsky
2010-02-06 20:18 ` [PATCH 3/6] dmfe: workaround chipset bug Maxim Levitsky
2010-02-06 20:19 ` [PATCH 4/6] DMFE: WOL fixes: Maxim Levitsky
2010-02-06 20:19 ` [PATCH 5/6] DMFE: add .shutdown Maxim Levitsky
2010-02-06 20:19 ` [PATCH 6/6] DMFE: don't reinitialize the hardware if device wasn't open Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210.131849.237007566.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim-levitsky@gmail.com \
--cc=maximlevitsky@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).