From: Stephen Hemminger <shemminger@vyatta.com>
To: Mike McCormack <mikem@ring3k.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/5] sky2: Allocate initial skbs in sky2_alloc_buffers
Date: Wed, 10 Feb 2010 08:04:52 -0800 [thread overview]
Message-ID: <20100210080452.75ee8ab2@nehalam> (raw)
In-Reply-To: <4B72BEB1.10908@ring3k.org>
On Wed, 10 Feb 2010 23:12:01 +0900
Mike McCormack <mikem@ring3k.org> wrote:
> + re->skb = sky2_rx_alloc(sky2);
> + if (!re->skb)
> + goto nomem;
> +
> + if (sky2_rx_map_skb(hw->pdev, re, sky2->rx_data_size)) {
> + dev_kfree_skb(re->skb);
> + re->skb = NULL;
> + goto nomem;
> + }
> + }
> + return 0;
> +nomem:
> + return -ENOMEM;
I like this and will put it all together with my patch set
But will get rid of silly things goto a return statement.
--
prev parent reply other threads:[~2010-02-10 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 14:12 [PATCH 2/5] sky2: Allocate initial skbs in sky2_alloc_buffers Mike McCormack
2010-02-10 16:04 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210080452.75ee8ab2@nehalam \
--to=shemminger@vyatta.com \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).