From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver
Date: Wed, 10 Feb 2010 09:09:46 -0800
Message-ID: <20100210090946.1de509ea@nehalam>
References: <201002100629.o1A6TFUk026363@blc-10-10.brocade.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, adapter_linux_open_src_team@brocade.com
To: Rasesh Mody <rmody@brocade.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.vyatta.com ([76.74.103.46]:36134 "EHLO mail.vyatta.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754358Ab0BJRKH (ORCPT <rfc822;netdev@vger.kernel.org>);
	Wed, 10 Feb 2010 12:10:07 -0500
In-Reply-To: <201002100629.o1A6TFUk026363@blc-10-10.brocade.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 9 Feb 2010 22:29:15 -0800
Rasesh Mody <rmody@brocade.com> wrote:

> +#define bnad_conf_lock()	down(&bnad->conf_sem)
> +#define bnad_conf_unlock()	up(&bnad->conf_sem)

Don't wrap locking in macros.
Don't use semaphores as locks, use mutex.

--