From: Stephen Hemminger <shemminger@vyatta.com>
To: Mike McCormack <mikem@ring3k.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] sky2: Avoid down and up during sky2_reset
Date: Wed, 10 Feb 2010 09:34:08 -0800 [thread overview]
Message-ID: <20100210093408.38a7f817@nehalam> (raw)
In-Reply-To: <4B72BEC9.4000004@ring3k.org>
On Wed, 10 Feb 2010 23:12:25 +0900
Mike McCormack <mikem@ring3k.org> wrote:
> + if (!interrupts_disabled) {
> + /* Disable port IRQ */
> + u32 imask = sky2_read32(hw, B0_IMSK);
> + imask &= ~portirq_msk[port];
> + sky2_write32(hw, B0_IMSK, imask);
> + sky2_read32(hw, B0_IMSK);
>
I don't like conditional context like this. It makes code
hard to debug, etc. Could you change sky2_down to do the irq
cleanup before calling hw_down?
--
prev parent reply other threads:[~2010-02-10 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 14:12 [PATCH 5/5] sky2: Avoid down and up during sky2_reset Mike McCormack
2010-02-10 17:34 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210093408.38a7f817@nehalam \
--to=shemminger@vyatta.com \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox