From: David Miller <davem@davemloft.net>
To: rdreier@cisco.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: Use explicit designated initializers for .cmd
Date: Thu, 11 Feb 2010 12:14:34 -0800 (PST) [thread overview]
Message-ID: <20100211.121434.97316024.davem@davemloft.net> (raw)
In-Reply-To: <adatytn7crt.fsf@roland-alpha.cisco.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Thu, 11 Feb 2010 12:12:06 -0800
> Initialize the .cmd member of various ethtool using a designated struct
> initializer rather. This makes things a teeny bit more robust, although
> the chance of a struct layout changing is extremely remote, and also
> makes the code a little easier to read.
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
Applied to net-next-2.6, thanks Roland.
prev parent reply other threads:[~2010-02-11 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 20:12 [PATCH] ethtool: Use explicit designated initializers for .cmd Roland Dreier
2010-02-11 20:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100211.121434.97316024.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).