From: David Miller <davem@davemloft.net>
To: haavard.skinnemoen@atmel.com
Cc: jpirko@redhat.com, netdev@vger.kernel.org, hskinnemoen@atmel.com
Subject: Re: [PATCH net-next-2.6] macb: straighten out macb_mii_probe function
Date: Fri, 12 Feb 2010 11:39:25 -0800 (PST) [thread overview]
Message-ID: <20100212.113925.249605315.davem@davemloft.net> (raw)
In-Reply-To: <20100210151706.6f12d431@hskinnemoen-d830>
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Date: Wed, 10 Feb 2010 15:17:06 +0530
> Jiri Pirko <jpirko@redhat.com> wrote:
>> Use "phy_find_first" instead of manual lookup. Also use "phy_connect_direct"
>> instead of "phy_connect" since we already have phy_device pointer here.
>>
>> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>
> Looks reasonable as far as I can see.
>
> Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Applied, thanks guys.
prev parent reply other threads:[~2010-02-12 19:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 15:12 [PATCH net-next-2.6] macb: straighten out macb_mii_probe function Jiri Pirko
2010-02-10 9:47 ` Haavard Skinnemoen
2010-02-12 19:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212.113925.249605315.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=haavard.skinnemoen@atmel.com \
--cc=hskinnemoen@atmel.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).