From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH net-2.6] sfc: Fix SFE4002 initialisation
Date: Fri, 12 Feb 2010 12:32:36 -0800 (PST) [thread overview]
Message-ID: <20100212.123236.90513347.davem@davemloft.net> (raw)
In-Reply-To: <1265730777.2126.110.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 09 Feb 2010 15:52:57 +0000
> From: Steve Hodgson <shodgson@solarflare.com>
>
> Commit 357d46a17e54c9a87e0e6ef3930ff4ab2d232b81 "sfc: QT202x: Remove
> unreliable MMD check at initialisation" broke initialisation of the
> SFE4002. efx_mdio_reset_mmd() returns a positive value rather than 0
> on success. The above commit causes this value to be propagated up
> by qt202x_reset_phy(), which is treated as a failure by its callers.
> Change qt202x_reset_phy() to return 0 if successful.
>
> The PCI layer treats >0 as "fail, but please call remove() anyway",
> which means that unloading the driver would cause a crash. Add a
> WARN_ON() on the failure path of efx_pci_probe() to provide early
> warning if there are any other cases where we do this.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied to net-2.6, thanks.
prev parent reply other threads:[~2010-02-12 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 15:52 [PATCH net-2.6] sfc: Fix SFE4002 initialisation Ben Hutchings
2010-02-12 20:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212.123236.90513347.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).