From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [RFC PATCH net-next 0/7] Add netdev_printk and netif_printk macros
Date: Fri, 12 Feb 2010 13:10:04 -0800 (PST) [thread overview]
Message-ID: <20100212.131004.197405614.davem@davemloft.net> (raw)
In-Reply-To: <20100212.123129.163263355.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 12 Feb 2010 12:31:29 -0800 (PST)
> All applied to net-next-2.6, thanks!
Hmmm, some build problems:
drivers/net/atl1e/atl1e_main.c: In function 'atl1e_vlan_rx_register':
drivers/net/atl1e/atl1e_main.c:322: error: 'struct net_device' has no member named 'adapter'
drivers/net/atl1e/atl1e_main.c:322: error: 'struct net_device' has no member named 'adapter'
drivers/net/atl1e/atl1e_main.c: In function 'atl1e_restore_vlan':
drivers/net/atl1e/atl1e_main.c:343: error: 'struct net_device' has no member named 'adapter'
drivers/net/atl1e/atl1e_main.c:343: error: 'struct net_device' has no member named 'adapter'
...
Passing in a derference like "adapter->netdev" as an argument doesn't work with these macros
end up giving us things like:
dev_driver_string((adapter->netdev)->adapter->netdev.parent)
and
dev_name((adapter->netdev)->adapter->netdev.parent)
The issue seems to be the netdev_dbg() define when DEBUG is not set and
CONFIG_DYNAMIC_DEBUG is set.
It goes "(dev)->dev.parent" and CPP has fun with that.
I'll use a different name for the first macro argument to netdev_dbg() and see
if that's enough to fix this.
next prev parent reply other threads:[~2010-02-12 21:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 21:49 [RFC PATCH net-next 0/7] Add netdev_printk and netif_printk macros Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 1/7] netdevice.h: Add netdev_printk helpers like dev_printk Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 2/7] drivers/net/atl1e: Use netdev_printk helpers Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 3/7] include/linux/netdevice.h: Add netif_printk helpers Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 4/7] drivers/net/r8196.c: Use netif_printk macros Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 5/7] drivers/net/jme: Use netif_printk helpers Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 6/7] drivers/net/qlge: " Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 7/7] drivers/net/skge.c: Use netif_printk macros Joe Perches
2010-02-12 20:31 ` [RFC PATCH net-next 0/7] Add netdev_printk and " David Miller
2010-02-12 21:10 ` David Miller [this message]
2010-02-13 4:12 ` Joe Perches
2010-02-13 4:40 ` David Miller
2010-02-15 0:47 ` [PATCH net-next] niu.c: Use pr_<level>, netdev_<level> and netif_<level> macros Joe Perches
2010-02-15 6:41 ` David Miller
2010-02-15 8:13 ` David Miller
2010-02-15 8:23 ` Joe Perches
2010-02-15 8:30 ` David Miller
2010-02-15 8:40 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212.131004.197405614.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).