From: David Miller <davem@davemloft.net>
To: caoco2002@yahoo.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: bug and question in tcp stack
Date: Fri, 12 Feb 2010 15:39:07 -0800 (PST) [thread overview]
Message-ID: <20100212.153907.71316958.davem@davemloft.net> (raw)
In-Reply-To: <157135.69931.qm@web63405.mail.re1.yahoo.com>
From: Joe Cao <caoco2002@yahoo.com>
Date: Fri, 12 Feb 2010 15:22:16 -0800 (PST)
> if (tcp_retransmit_skb(sk, tcp_write_queue_head(sk)) > 0) {
>
> checks the return value as a positive number, which will never be true.
It can, recheck the code paths.
The upcall to send an SKB out through the packet schedular and onwards
to the actual device can return congestion notification values, which
are positive.
prev parent reply other threads:[~2010-02-12 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 23:22 bug and question in tcp stack Joe Cao
2010-02-12 23:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212.153907.71316958.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=caoco2002@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).