Re: Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[David Miller <davem@davemloft.net>]

From: Rasesh Mody <rmody@brocade.com>
Date: Fri, 12 Feb 2010 06:00:57 -0800

> From: Rasesh Mody <rmody@brocade.com>
> 
> This is patch 0/6 which contains the summary of changes we've
> done in this particular submission for Brocade's BR1010/BR1020
> 10Gb CEE capable ethernet adapter. Source is based against
> net-next-2.6.
> 
> The changes are as follows:
> 
> 1) Cleaned up extra BUG_ON()
> 
> 2) Using mutex wherever appropriate
> 
> 3) Using PCI_DEVICE_TABLE
> 
> We wish this patch to be considered for inclusion in net-next-2.6.
> 
> Signed-off-by: Rasesh Mody <rmody@brocade.com>

The driver doesn't build:

drivers/net/bna/bnad.c: In function ‘bnad_alloc_unmap_q’:
drivers/net/bna/bnad.c:850: error: implicit declaration of function ‘vmalloc’
drivers/net/bna/bnad.c:850: warning: assignment makes pointer from integer without a cast
drivers/net/bna/bnad.c: In function ‘bnad_free_txq’:
drivers/net/bna/bnad.c:1319: error: implicit declaration of function ‘vfree’
drivers/net/bna/bnad.c: In function ‘bnad_priv_init’:
drivers/net/bna/bnad.c:3163: warning: assignment makes pointer from integer without a cast

Second, the driver header files make reference to global functions which do
not exist, such as bna_ioctl_init() and friends.  Please remove those.

Lastly, some of the files added have extra trailing empty lines, please remove
them.

Thanks.