From: David Miller <davem@davemloft.net>
To: fujita.tomonori@lab.ntt.co.jp
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
mb@bu3sch.de, stefano.brivio@polimi.it,
Larry.Finger@lwfinger.net, akpm@linux-foundation.org
Subject: Re: [PATCH -mm] ssb: open-code dma_alloc_coherent
Date: Sun, 14 Feb 2010 22:24:46 -0800 (PST) [thread overview]
Message-ID: <20100214.222446.138687519.davem@davemloft.net> (raw)
In-Reply-To: <20100215142111R.fujita.tomonori@lab.ntt.co.jp>
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Mon, 15 Feb 2010 14:21:58 +0900
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH -mm] ssb: open-code dma_alloc_coherent
>
> This removes ssb_dma_alloc_consistent, a wrapper for
> dma_alloc_coherent and pci_alloc_consistent. dma_alloc_coherent
> internally calls pci_alloc_consistent against pci devices so we always
> use dma_alloc_coherent.
>
> I prefer to use the DMA API directly instead of creating the ssb_dma_
> API. We have been removing any bus specific DMA APIs.
>
> One disadvantage of this approach that we lost the debugging ability
> of checking the buggy usage of the DMA API against non DMA-capable ssb
> buses. But I guess that the ssb drivers are mature enough and can cope
> with such change?
>
> I plan to replace all the ssb_dma API if this approach is fine.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
I'm fine with this:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2010-02-15 6:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 5:21 [PATCH -mm] ssb: open-code dma_alloc_coherent FUJITA Tomonori
2010-02-15 6:24 ` David Miller [this message]
2010-02-15 6:49 ` Larry Finger
2010-02-15 7:25 ` FUJITA Tomonori
2010-02-15 10:09 ` FUJITA Tomonori
2010-02-16 0:09 ` Larry Finger
2010-02-16 2:05 ` FUJITA Tomonori
2010-02-16 19:12 ` Larry Finger
2010-02-15 11:03 ` Michael Buesch
2010-02-15 11:18 ` FUJITA Tomonori
2010-02-15 11:21 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100214.222446.138687519.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox