netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [PATCH net-next] niu.c: Use pr_<level>, netdev_<level> and netif_<level> macros
Date: Sun, 14 Feb 2010 22:41:08 -0800 (PST)	[thread overview]
Message-ID: <20100214.224108.51485961.davem@davemloft.net> (raw)
In-Reply-To: <1266194829.16721.940.camel@Joe-Laptop.home>

From: Joe Perches <joe@perches.com>
Date: Sun, 14 Feb 2010 16:47:09 -0800

> OK David, here you go.
> 
> I'm not sure of the conversions of:
> 	dev_<level>(np->device,...
> to
> 	netdev_<level>(np->dev,...
> 
> It compiles, but dunno if it's correct (no hw to test)
> 
> Remove #define PFX
> Add pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Convert printks to pr_<level>
> Convert printks without levels to pr_cont
> Convert pr_<level> with np->dev to netdev_<level>
> Convert dev_<level> to netdev_<level>
> Convert niudbg to netif_printk
> Convert niuinfo, niuwarn macros to netif_<level>(priv, type, dev...
> Coalesce long formats
> Convert embedded function names to "%s", __func__
> Always use "%s()..." when __func__ is printed
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Thanks Joe.

It looks good here and I'll give it a quick test before
doing a final push of this into net-next-2.6

Thanks!

  reply	other threads:[~2010-02-15  6:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-09 21:49 [RFC PATCH net-next 0/7] Add netdev_printk and netif_printk macros Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 1/7] netdevice.h: Add netdev_printk helpers like dev_printk Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 2/7] drivers/net/atl1e: Use netdev_printk helpers Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 3/7] include/linux/netdevice.h: Add netif_printk helpers Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 4/7] drivers/net/r8196.c: Use netif_printk macros Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 5/7] drivers/net/jme: Use netif_printk helpers Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 6/7] drivers/net/qlge: " Joe Perches
2010-02-09 21:49 ` [RFC PATCH net-next 7/7] drivers/net/skge.c: Use netif_printk macros Joe Perches
2010-02-12 20:31 ` [RFC PATCH net-next 0/7] Add netdev_printk and " David Miller
2010-02-12 21:10   ` David Miller
2010-02-13  4:12     ` Joe Perches
2010-02-13  4:40       ` David Miller
2010-02-15  0:47   ` [PATCH net-next] niu.c: Use pr_<level>, netdev_<level> and netif_<level> macros Joe Perches
2010-02-15  6:41     ` David Miller [this message]
2010-02-15  8:13       ` David Miller
2010-02-15  8:23         ` Joe Perches
2010-02-15  8:30           ` David Miller
2010-02-15  8:40             ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100214.224108.51485961.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).