From: David Miller <davem@davemloft.net>
To: mingo@elte.hu
Cc: eric.dumazet@gmail.com, paulmck@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com,
dipankar@in.ibm.com, akpm@linux-foundation.org,
mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org,
dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH tip/core/rcu 05/13] net: add checking to rcu_dereference() primitives
Date: Sun, 14 Feb 2010 23:18:27 -0800 (PST) [thread overview]
Message-ID: <20100214.231827.257182182.davem@davemloft.net> (raw)
In-Reply-To: <20100214082314.GA12658@elte.hu>
From: Ingo Molnar <mingo@elte.hu>
Date: Sun, 14 Feb 2010 09:23:14 +0100
>
> * Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> Le jeudi 11 f??vrier 2010 ?? 16:00 -0800, Paul E. McKenney a ??crit :
>> > Update rcu_dereference() primitives to use new lockdep-based checking.
>> > The rcu_dereference() in __in6_dev_get() may be protected either by
>> > rcu_read_lock() or RTNL, per Eric Dumazet. The rcu_dereference()
>> > in __sk_free() is protected by the fact that it is never reached if an
>> > update could change it. Check for this by using rcu_dereference_check()
>> > to verify that the struct sock's ->sk_wmem_alloc counter is zero.
>> >
>> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>>
>> CC to netdev and David Miller, network maintainer.
>>
>> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>>
>> Thanks Paul, great work !
>
> Dave, does this look good to you too? Cannot pick up the rest of the patchset
> without these checks/annotations into the RCU tree as there's too many
> warnings triggering in the networking code. So it's an all-or-nothing
> patchset in that regard.
Looks good:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2010-02-15 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100212000016.GA25781@linux.vnet.ibm.com>
[not found] ` <1265932839-25899-5-git-send-email-paulmck@linux.vnet.ibm.com>
2010-02-12 4:15 ` [PATCH tip/core/rcu 05/13] net: add checking to rcu_dereference() primitives Eric Dumazet
2010-02-14 8:23 ` Ingo Molnar
2010-02-15 7:18 ` David Miller [this message]
2010-02-14 8:34 ` Michał Mirosław
2010-02-14 8:50 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100214.231827.257182182.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).