From: David Miller <davem@davemloft.net>
To: birrachiara@tin.it
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: [PATCH] SiS190/191 half-duplex initialization fix
Date: Tue, 16 Feb 2010 14:47:56 -0800 (PST) [thread overview]
Message-ID: <20100216.144756.71882700.davem@davemloft.net> (raw)
In-Reply-To: <1266265140-20196-1-git-send-email-birrachiara@tin.it>
From: Riccardo Ghetta <birrachiara@tin.it>
Date: Mon, 15 Feb 2010 21:19:00 +0100
> + u32 negotiated_lpa;
Uses spaces instead of tabs.
> + tp->negotiated_lpa = p->val;
Has a space then tabs, should be all tab characters.
> + if (tp->negotiated_lpa & (LPA_1000HALF | LPA_100HALF | LPA_10HALF))
> + {
Should be:
if (condition) {
ie. the openning brace need to be on the same line as the if
statement.
Please fix these issues up and resubmit your patch, thanks.
next prev parent reply other threads:[~2010-02-16 22:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 20:19 [PATCH] SiS190/191 half-duplex initialization fix Riccardo Ghetta
2010-02-16 22:47 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-17 19:28 Riccardo Ghetta
2010-02-17 21:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216.144756.71882700.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=birrachiara@tin.it \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).