From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: adobriyan@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ipcomp: double free at ipcomp_destroy()
Date: Tue, 16 Feb 2010 15:14:34 -0800 (PST) [thread overview]
Message-ID: <20100216.151434.179169672.davem@davemloft.net> (raw)
In-Reply-To: <20100216052430.GA27643@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 16 Feb 2010 13:24:30 +0800
> On Mon, Feb 15, 2010 at 07:28:10PM +0200, Alexey Dobriyan wrote:
>>
>> OK, it survives beating here.
>
> Thanks a lot for testing! I'll do the clean-up you suggested in
> another patch. Let's get this fixed first.
>
> ipcomp: Avoid duplicate calls to ipcomp_destroy
>
> When ipcomp_tunnel_attach fails we will call ipcomp_destroy twice.
> This may lead to double-frees on certain structures.
>
> As there is no reason to explicitly call ipcomp_destroy, this patch
> removes it from ipcomp*.c and lets the standard xfrm_state destruction
> take place.
>
> This is based on the discovery and patch by Alexey Dobriyan.
>
> Tested-by: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied to net-2.6
next prev parent reply other threads:[~2010-02-16 23:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 14:44 [PATCH] ipcomp: double free at ipcomp_destroy() Alexey Dobriyan
2010-02-15 0:18 ` Herbert Xu
2010-02-15 7:32 ` Alexey Dobriyan
2010-02-15 8:08 ` Herbert Xu
2010-02-15 8:10 ` Herbert Xu
2010-02-15 15:50 ` Alexey Dobriyan
2010-02-16 5:29 ` Herbert Xu
2010-02-15 17:28 ` Alexey Dobriyan
2010-02-16 5:24 ` Herbert Xu
2010-02-16 23:14 ` David Miller [this message]
2010-02-16 6:00 ` Herbert Xu
2010-02-16 23:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216.151434.179169672.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).