From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: netdev@vger.kernel.org, stefano.babic@babic.homelinux.org,
randy.dunlap@oracle.com, daniel.martensson@stericsson.com,
kaber@trash.net, marcel@holtmann.org
Subject: Re: [PATCH net-next-2.6 v2 02/12] net-caif: add CAIF socket and configuration headers
Date: Tue, 16 Feb 2010 15:40:52 -0800 (PST) [thread overview]
Message-ID: <20100216.154052.35003691.davem@davemloft.net> (raw)
In-Reply-To: <1266328017-28406-3-git-send-email-sjur.brandeland@stericsson.com>
From: sjur.brandeland@stericsson.com
Date: Tue, 16 Feb 2010 14:46:47 +0100
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
Sorry, we really don't make amends for C++ to use the kernel
headers in this way.
If you look at other headers defining user visible datastructures
there is really no precendence for doing what you're doing here.
Please remove these __cplusplus things and resubmit your patch
set, thank you.
prev parent reply other threads:[~2010-02-16 23:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 13:46 [PATCH net-next-2.6 v2 00/12] net-caif: introducing CAIF protocol stack sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 01/12] net-caif: add CAIF protocol definitions sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 02/12] net-caif: add CAIF socket and configuration headers sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 03/12] net-caif: add CAIF core protocol stack header files sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 04/12] net-caif: add CAIF Link layer device " sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 05/12] net-caif: add CAIF core protocol stack sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 06/12] net-caif: add CAIF generic caif support functions sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 07/12] net-caif: add CAIF device registration functionality sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 08/12] net-caif: add CAIF socket implementation sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 09/12] net-caif: add CAIF netdevice sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 10/12] net-caif: add CAIF Kconfig and Makefiles sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 11/12] net-caif: add CAIF documentation sjur.brandeland
2010-02-16 13:46 ` [PATCH net-next-2.6 v2 12/12] net-caif-driver: add CAIF serial driver (ldisc) sjur.brandeland
2010-02-16 15:57 ` [PATCH net-next-2.6 v2 08/12] net-caif: add CAIF socket implementation Marcel Holtmann
2010-02-16 23:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216.154052.35003691.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel.martensson@stericsson.com \
--cc=kaber@trash.net \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sjur.brandeland@stericsson.com \
--cc=stefano.babic@babic.homelinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).