From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ethtool: Don't flush n-tuple list from ethtool_reset() Date: Wed, 17 Feb 2010 13:39:34 -0800 (PST) Message-ID: <20100217.133934.143869560.davem@davemloft.net> References: <1266434814.2090.6.camel@achroite.uk.solarflarecom.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: bhutchings@solarflare.com, netdev@vger.kernel.org To: peter.p.waskiewicz.jr@intel.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:44238 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754848Ab0BQVjT (ORCPT ); Wed, 17 Feb 2010 16:39:19 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: "Waskiewicz Jr, Peter P" Date: Wed, 17 Feb 2010 11:29:33 -0800 (Pacific Standard Time) > On Wed, 17 Feb 2010, Ben Hutchings wrote: > >> The n-tuple list should be flushed if and only if the ETH_RESET_FILTER >> flag is set and the driver is able to reset filtering/flow direction >> hardware without also resetting a component whose flag is not set. >> This test is best left to the driver. >> >> Signed-off-by: Ben Hutchings > > Yes, this was the intent. Thanks for cleaning this bit up in the ethtool > core. Patch applied, thanks everyone.