[PATCH] ethtool: Don't flush n-tuple list from ethtool_reset()

[PATCH] ethtool: Don't flush n-tuple list from ethtool_reset()

[Ben Hutchings]

The n-tuple list should be flushed if and only if the ETH_RESET_FILTER
flag is set and the driver is able to reset filtering/flow direction
hardware without also resetting a component whose flag is not set.
This test is best left to the driver.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
 net/core/ethtool.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index d08a0c7..31b1edd 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -654,9 +654,6 @@ static int ethtool_reset(struct net_device *dev, char __user *useraddr)
 	if (copy_from_user(&reset, useraddr, sizeof(reset)))
 		return -EFAULT;
 
-	/* Clear ethtool n-tuple list */
-	ethtool_ntuple_flush(dev);
-
 	ret = dev->ethtool_ops->reset(dev, &reset.data);
 	if (ret)
 		return ret;
-- 
1.6.2.5

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Re: [PATCH] ethtool: Don't flush n-tuple list from ethtool_reset()

[Waskiewicz Jr, Peter P]

On Wed, 17 Feb 2010, Ben Hutchings wrote:

> The n-tuple list should be flushed if and only if the ETH_RESET_FILTER
> flag is set and the driver is able to reset filtering/flow direction
> hardware without also resetting a component whose flag is not set.
> This test is best left to the driver.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

Yes, this was the intent.  Thanks for cleaning this bit up in the ethtool 
core.

-PJ

Re: [PATCH] ethtool: Don't flush n-tuple list from ethtool_reset()

[David Miller]

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Date: Wed, 17 Feb 2010 11:29:33 -0800 (Pacific Standard Time)

> On Wed, 17 Feb 2010, Ben Hutchings wrote:
> 
>> The n-tuple list should be flushed if and only if the ETH_RESET_FILTER
>> flag is set and the driver is able to reset filtering/flow direction
>> hardware without also resetting a component whose flag is not set.
>> This test is best left to the driver.
>> 
>> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> 
> Yes, this was the intent.  Thanks for cleaning this bit up in the ethtool 
> core.

Patch applied, thanks everyone.