Re: [net-next-2.6 PATCH 1/3] vlan: adds vlan_dev_select_queue

[David Miller <davem@davemloft.net>]

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 17 Feb 2010 14:51:15 +0100

> This is a bit dangerous and deserves a self contained patch IMHO.
> 
> I would add for example a
> 	BUG_ON(vlandev->real_num_tx_queues > vlandev->num_tx_queues)
> 
> ------------------
> 
> For performance reason, we could avoid calling vlan_dev_select_queue()
> for real devices without ndo_select_queue() handler, this would need to
> mirror vlan_netdev_ops & vlan_netdev_accel_ops.
> 
> It would also make vlan_dev_select_queue shorter and not duplicates
> internals of net/dev/core.c :
> 
> static u16 vlan_dev_select_queue(struct net_device *dev, struct sk_buff
> *skb)
> {
>        struct net_device *rdev = vlan_dev_info(dev)->real_dev;
>        const struct net_device_ops *ops = rdev->netdev_ops;
> 
>        return ops->ndo_select_queue(rdev, skb);
> }
> 
> 

Jeff, please resubmit this patch set after addressing
Eric's feedback.

Thanks!