From: David Miller <davem@davemloft.net>
To: william.allen.simpson@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
akpm@linux-foundation.org, mchan@broadcom.com
Subject: Re: [PATCH v3 2/7] net: remove old tcp_optlen function
Date: Wed, 17 Feb 2010 15:43:32 -0800 (PST) [thread overview]
Message-ID: <20100217.154332.137835825.davem@davemloft.net> (raw)
In-Reply-To: <4B7793A7.1010500@gmail.com>
From: William Allen Simpson <william.allen.simpson@gmail.com>
Date: Sun, 14 Feb 2010 01:09:43 -0500
> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
> index 65df1de..45452c5 100644
> --- a/drivers/net/bnx2.c
> +++ b/drivers/net/bnx2.c
> @@ -6352,6 +6352,8 @@ bnx2_vlan_rx_register(struct net_device *dev, struct vlan_group *vlgrp)
> /* Called with netif_tx_lock.
> * bnx2_tx_int() runs without netif_tx_lock unless it needs to call
> * netif_wake_queue().
> + *
> + * No TCP or IP length checking, per David Miller (see commit log).
> */
This is not appropriate, please do not do this.
We do not refer to commit log messages from the source code. Many
people have the sources via some other means (tarball, distribution
source package, etc.) and won't have any idea where to get this
information.
Also, you don't need to single me out personally. This is an
implication of the structure of the code that I've merely explained to
you, it's not some rule I've personally decided upon.
Thanks.
next prev parent reply other threads:[~2010-02-17 23:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 6:01 [PATCH 0/7] tcp: bugs and cleanup updated to 2.6.33-rc8 William Allen Simpson
2010-02-14 6:05 ` [PATCH v3 1/7] net: tcp_header_len_th and tcp_option_len_th William Allen Simpson
2010-02-14 6:09 ` [PATCH v3 2/7] net: remove old tcp_optlen function William Allen Simpson
2010-02-17 23:43 ` David Miller [this message]
2010-02-14 6:16 ` [PATCH v5 3/7] tcp: harmonize tcp_vx_rcv header length assumptions William Allen Simpson
2010-02-17 23:47 ` David Miller
2010-02-14 6:21 ` [PATCH v4 4/7] tcp: input header length, prediction, and timestamp bugs William Allen Simpson
2010-02-17 23:50 ` David Miller
2010-02-14 6:26 ` [PATCH v3 5/7] TCPCT part 2e: accept SYNACK data William Allen Simpson
2010-02-14 6:41 ` [PATCH v4 6/7] TCPCT part 2f: cleanup tcp_parse_options William Allen Simpson
2010-02-14 7:02 ` [PATCH v6 7/7] TCPCT part 2g: parse cookie pair and 64-bit timestamp William Allen Simpson
-- strict thread matches above, loose matches on Subject: below --
2010-02-15 12:23 [PATCH 0/7] tcp: bugs and cleanup updated to 2.6.33-rc8 (again) William Allen Simpson
2010-02-15 12:27 ` [PATCH v3 2/7] net: remove old tcp_optlen function William Allen Simpson
2010-02-25 20:30 [PATCH 0/7] tcp: bugs and cleanup for 2.6.33 William Allen Simpson
2010-02-25 20:39 ` [PATCH v3 2/7] net: remove old tcp_optlen function William Allen Simpson
2010-02-25 20:55 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217.154332.137835825.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=william.allen.simpson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).