From: David Miller <davem@davemloft.net>
To: apetlund@simula.no
Cc: netdev@vger.kernel.org, ilpo.jarvinen@helsinki.fi,
eric.dumazet@gmail.com, hannemann@nets.rwth-aachen.de,
linux-kernel@vger.kernel.org, shemminger@vyatta.com,
william.allen.simpson@gmail.com, damian@tvk.rwth-aachen.de,
ebiederm@xmission.com
Subject: Re: [net-next PATCH v4 2/3] net: TCP thin linear timeouts
Date: Wed, 17 Feb 2010 16:32:55 -0800 (PST) [thread overview]
Message-ID: <20100217.163255.133898079.davem@davemloft.net> (raw)
In-Reply-To: <4B7AAE69.8020701@simula.no>
From: Andreas Petlund <apetlund@simula.no>
Date: Tue, 16 Feb 2010 15:40:41 +0100
> @@ -341,6 +342,8 @@ struct tcp_sock {
> u16 advmss; /* Advertised MSS */
> u8 frto_counter; /* Number of new acks after RTO */
> u8 nonagle; /* Disable Nagle algorithm? */
> + u8 thin_lto : 1,/* Use linear timeouts for thin streams */
> + thin_undef : 7;
>
There is now a gap of 3 unused bytes here in this critical
core TCP socket data structure.
Please either find a way to avoid this hole, or document
it with a comment.
next prev parent reply other threads:[~2010-02-18 0:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 14:40 [net-next PATCH v4 2/3] net: TCP thin linear timeouts Andreas Petlund
2010-02-18 0:32 ` David Miller [this message]
2010-02-18 8:41 ` Ilpo Järvinen
2010-02-18 8:44 ` Andreas Petlund
2010-02-18 9:01 ` Franco Fichtner
2010-02-18 9:09 ` Ilpo Järvinen
2010-02-18 9:18 ` Andreas Petlund
2010-02-18 9:24 ` Ilpo Järvinen
2010-02-18 9:25 ` Franco Fichtner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217.163255.133898079.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=apetlund@simula.no \
--cc=damian@tvk.rwth-aachen.de \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=hannemann@nets.rwth-aachen.de \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=william.allen.simpson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).