From: David Miller <davem@davemloft.net>
To: dave@thedillows.org
Cc: joe@perches.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 14/15] drivers/net/typhoon.c: Use (pr|netdev)_<level> macro helpers
Date: Wed, 17 Feb 2010 18:41:00 -0800 (PST) [thread overview]
Message-ID: <20100217.184100.232538560.davem@davemloft.net> (raw)
In-Reply-To: <1266460221.5719.60.camel@obelisk.thedillows.org>
From: David Dillow <dave@thedillows.org>
Date: Wed, 17 Feb 2010 21:30:21 -0500
> No, because the routines that use tp->name are called both before and
> after the netdev is registered. Prior to that time, it contains the PCI
> slot name -- "00:01.0" etc -- so that the user can determine which card
> is acting up. Once the card is registered, it has "ethX" to use a
> commonly expected name for the card.
In my opinion that's awful.
Pick one or the other format. For things that happen both
before and after netdev registry we really should provide
one style of device identification and those provided
by dev_*() are probably the best in these situations.
next prev parent reply other threads:[~2010-02-18 2:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 1:01 [PATCH net-next 00/15] drivers/net: Use (pr|netdev|netif)_<level> macros Joe Perches
2010-02-18 1:01 ` [PATCH net-next 01/15] drivers/net/8139cp.c: Use (pr|netdev|netif)_<level> macro helpers Joe Perches
2010-02-18 1:01 ` [PATCH net-next 02/15] drivers/net/8139too.c: " Joe Perches
2010-02-18 1:01 ` [PATCH net-next 03/15] drivers/net/b44.c: " Joe Perches
2010-02-18 1:01 ` [PATCH net-next 04/15] drivers/net/bnx2.c: " Joe Perches
2010-02-18 1:01 ` [PATCH net-next 05/15] drivers/net/bnx2x: " Joe Perches
2010-02-18 1:01 ` [PATCH net-next 06/15] drivers/net/cassini.c: " Joe Perches
2010-02-18 1:01 ` [PATCH net-next 07/15] drivers/net/cnic.c: Use (pr|netdev)_<level> " Joe Perches
2010-02-18 1:01 ` [PATCH net-next 08/15] drivers/net/pci-skeleton.c: Use (pr|netdev|netif)_<level> " Joe Perches
2010-02-18 1:01 ` [PATCH net-next 09/15] drivers/net/sis190.c: " Joe Perches
2010-02-18 6:00 ` [PATCH V2 " Joe Perches
2010-02-18 23:44 ` David Miller
2010-02-18 1:01 ` [PATCH net-next 10/15] drivers/net/skge.c: Use (pr|netdev)_<level> " Joe Perches
2010-02-18 1:01 ` [PATCH net-next 11/15] " Joe Perches
2010-02-18 1:01 ` [PATCH net-next 12/15] drivers/net/sky2.c: " Joe Perches
2010-02-18 1:02 ` [PATCH net-next 13/15] drivers/net/tg3.c: " Joe Perches
2010-02-18 5:44 ` [PATCH V2 " Joe Perches
2010-02-18 23:44 ` David Miller
2010-02-18 1:02 ` [PATCH net-next 14/15] drivers/net/typhoon.c: " Joe Perches
2010-02-18 1:59 ` David Dillow
2010-02-18 2:18 ` Joe Perches
2010-02-18 2:30 ` David Dillow
2010-02-18 2:41 ` David Miller [this message]
2010-02-18 3:01 ` David Dillow
2010-02-18 3:10 ` David Miller
2010-02-18 3:22 ` David Dillow
[not found] ` <1266467718.8446.251.camel@Joe-Laptop.home>
[not found] ` <1266795829.2930.8.camel@obelisk.thedillows.org>
[not found] ` <1266804176.10646.65.camel@Joe-Laptop.home>
2010-02-22 3:08 ` [PATCH V2 " Joe Perches
2010-02-22 3:23 ` David Dillow
2010-02-22 23:43 ` David Miller
2010-02-23 0:22 ` David Dillow
2010-02-23 0:45 ` David Miller
2010-02-22 23:47 ` David Miller
2010-02-18 3:11 ` [PATCH " Joe Perches
2010-02-18 2:53 ` Joe Perches
2010-02-18 3:18 ` David Dillow
2010-02-18 1:02 ` [PATCH net-next 15/15] drivers/net/yellowfin.c: " Joe Perches
2010-02-18 1:46 ` [PATCH net-next 00/15] drivers/net: Use (pr|netdev|netif)_<level> macros David Miller
2010-02-18 2:00 ` David Dillow
2010-02-18 2:01 ` David Miller
2010-02-18 2:06 ` David Miller
2010-02-18 2:19 ` David Dillow
2010-02-18 2:20 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217.184100.232538560.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dave@thedillows.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).