netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Kagstrom <simon.kagstrom@netinsight.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, krkumar2@in.ibm.com
Subject: Re: [net-next PATCH] via-velocity: Enable scatter/gather IO by default
Date: Wed, 17 Feb 2010 07:19:44 +0100	[thread overview]
Message-ID: <20100217071944.14183e50@marrow.netinsight.se> (raw)
In-Reply-To: <20100216.162015.77292959.davem@davemloft.net>

On Tue, 16 Feb 2010 16:20:15 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> > Reduces CPU utilization significantly with sendfile for example.
> > 
> > Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> 
> I think you need to have a look at this patch before making
> a change like this:
> 
> commit 83c98a8cd04dd0f848574370594886ba3bf56750
> Author: Dave Jones <davej@redhat.com>
> Date:   Tue Jul 21 09:15:49 2009 +0000
> 
>     Remove unused zero-copy code from velocity NIC driver.
>     
>     This code hasn't been enabled in forever.

Well I reenabled it here:

  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c79992fddee28bbd31b35ac297e1068d32930179

it was also cleaned up to remove all the #ifdefs around that code.

// Simon

  reply	other threads:[~2010-02-17  6:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 15:39 [net-next PATCH] via-velocity: Enable scatter/gather IO by default Simon Kagstrom
2010-02-17  0:20 ` David Miller
2010-02-17  6:19   ` Simon Kagstrom [this message]
2010-02-17  6:23     ` David Miller
2010-02-18  0:01 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100217071944.14183e50@marrow.netinsight.se \
    --to=simon.kagstrom@netinsight.net \
    --cc=davem@davemloft.net \
    --cc=krkumar2@in.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).