From: Philippe De Muyter <phdm@macqel.be>
To: David Miller <davem@davemloft.net>
Cc: chas3@users.sourceforge.net, chas@cmf.nrl.navy.mil,
netdev@vger.kernel.org
Subject: Re: [PATCH] atm : fix /sys/devices/virtual/atm/X/carrier(ATM_PHY_SIG_UNKNOWN)
Date: Wed, 17 Feb 2010 12:35:29 +0100 [thread overview]
Message-ID: <20100217113529.GA18818@frolo.macqel> (raw)
In-Reply-To: <20100216.221651.189702430.davem@davemloft.net>
Hi Chas, David,
On Tue, Feb 16, 2010 at 10:16:51PM -0800, David Miller wrote:
> From: "Chas Williams (CONTRACTOR)" <chas@cmf.nrl.navy.mil>
> Date: Sun, 14 Feb 2010 16:34:40 -0500
>
> > as i said before there is carrier or there is not. if the driver
> > doesnt support checking/knowing the carrier status it should simply
> > say 'yes i have carrier'.
>
> I agree %100 and this is how we handle similar situations
> for other networking device types.
I also agree 100% with that : the low-level driver must do that, not the
generic class driver. Here cxacru is punished because other atm drivers
forget to set signal = ATM_PHY_SIG_FOUND.
Philippe
next prev parent reply other threads:[~2010-02-17 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 21:56 [PATCH] atm : fix /sys/devices/virtual/atm/X/carrier(ATM_PHY_SIG_UNKNOWN) Philippe De Muyter
2010-02-13 23:24 ` Chas Williams (CONTRACTOR)
2010-02-14 17:51 ` Philippe De Muyter
2010-02-14 21:34 ` Chas Williams (CONTRACTOR)
2010-02-17 6:16 ` David Miller
2010-02-17 11:35 ` Philippe De Muyter [this message]
2010-02-18 14:22 ` Chas Williams (CONTRACTOR)
2013-08-08 8:34 ` Philippe De Muyter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217113529.GA18818@frolo.macqel \
--to=phdm@macqel.be \
--cc=chas3@users.sourceforge.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox