From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, kristoffer@gaisler.com
Subject: Re: linux-next: build failure after final merge (net tree)
Date: Thu, 18 Feb 2010 23:33:21 -0800 (PST) [thread overview]
Message-ID: <20100218.233321.226788593.davem@davemloft.net> (raw)
In-Reply-To: <20100219173713.e3f9f386.sfr@canb.auug.org.au>
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 19 Feb 2010 17:37:13 +1100
> I assume that this driver was written and tested only on Sparc
> ... maybe it should depend on SPARC?
Indeed, it should. I thought for some reason that all OF
platforms have of_remap() and of_device->resource[], oh
well :-)
Will commit the following, thanks!
net: Make GRETH driver depend on SPARC.
Reported by Stephen Rothwell.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 17ff15f..46af867 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -997,7 +997,7 @@ config ETHOC
config GRETH
tristate "Aeroflex Gaisler GRETH Ethernet MAC support"
- depends on OF
+ depends on SPARC
select PHYLIB
select CRC32
help
--
1.6.6.1
next prev parent reply other threads:[~2010-02-19 7:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 6:37 linux-next: build failure after final merge (net tree) Stephen Rothwell
2010-02-19 6:53 ` David Miller
2010-02-19 7:33 ` David Miller [this message]
2010-02-19 7:45 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2010-02-17 6:40 Stephen Rothwell
2010-02-17 6:46 ` Stephen Rothwell
2010-02-17 7:11 ` David Miller
2010-02-17 7:57 ` Stephen Rothwell
2010-02-17 7:13 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100218.233321.226788593.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kristoffer@gaisler.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox